httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@znep.com>
Subject [PATCH] TCP_NODELAY (was : Re: [COMPILE]: "compile blows up on "TCP_NODELAY" - not defined" on OTHER:SVR4 (fwd))
Date Wed, 12 Feb 1997 07:27:00 GMT
On Sat, 8 Feb 1997, Rob Hartill wrote:

> 
> ---------- Forwarded message ----------
> Date: Sat Feb 8 15:01:08 1997
> From: johnhal@netzone.com
> To: apache-bugs%apache.org@organic.com
> Subject: [BUG]: "compile blows up on "TCP_NODELAY" - not defined" on OTHER:SVR4
> 
> Submitter: johnhal@netzone.com
> Operating system: OTHER:SVR4, version: MPRAS (NCR)
> Version of Apache Used: 1.2.6b (latest)
> Extra Modules used: none on 2nd try
> URL exhibiting problem: sorry, behind a firewall
> 
> Symptoms:
> --
> I must be missing a header file or library.  
> Blows up in http_main complaining about
>  "TCP_NODELAY".  I am not at work as I write,
>  so don't have the exact error message.
> I am compiling on an NCR 3430 running UNIX 
> SVR4 MP RAS (whatever that is).
> 
> I was successful in compling NCSA's 1.5a
>  about 6 months ago (it is currently running)
> 
> Thanks for your help.
> 

(patch sent to user)

I say just don't compile that bit when TCP_NODELAY isn't defined.  Not
sure if the MPE ifdef is still needed; could be that TCP_NODELAY is
defined but makes it blow up.  

Index: http_main.c
===================================================================
RCS file: /export/home/cvs/apache/src/http_main.c,v
retrieving revision 1.118
diff -c -r1.118 http_main.c
*** http_main.c	1997/02/10 21:22:20	1.118
--- http_main.c	1997/02/12 07:20:58
***************
*** 1500,1508 ****
       *
       * In spite of these problems, failure here is not a shooting offense.
       */
!     const int just_say_no = 1;
! #ifndef MPE
  /* MPE does not support TCP_NODELAY */
      if (0 != setsockopt(s, IPPROTO_TCP, TCP_NODELAY, (char*)&just_say_no,
  			sizeof(just_say_no)))
  	fprintf(stderr, "httpd: could not set socket option TCP_NODELAY\n");
--- 1542,1550 ----
       *
       * In spite of these problems, failure here is not a shooting offense.
       */
! #if defined(TCP_NODELAY) && !defined(MPE)
  /* MPE does not support TCP_NODELAY */
+     const int just_say_no = 1;
      if (0 != setsockopt(s, IPPROTO_TCP, TCP_NODELAY, (char*)&just_say_no,
  			sizeof(just_say_no)))
  	fprintf(stderr, "httpd: could not set socket option TCP_NODELAY\n");


Mime
View raw message