httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@znep.com>
Subject Re: [PATCH] Don't propagate EXTRA_CFLAGS to regex library
Date Wed, 12 Feb 1997 02:15:18 GMT
Like the idea and think it may be worthwhile; the changes aren't that big,
they just look that way.

See my comments below.

On Mon, 10 Feb 1997, Dean Gaudet wrote:

> On Mon, 10 Feb 1997, Roy T. Fielding wrote:
> 
> > Since we aren't going to fix the warnings, this is the easiest way
> > to make them go away without risking breakage.
> 
> I made a patch to fix them, but I'm not really happy about applying it.
> Anyhow the patch is included, lightly tested.
> 
> --- 91,96 ----
> Index: regex/regexec.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/regex/regexec.c,v
> retrieving revision 1.1
> diff -c -3 -r1.1 regexec.c
> *** regexec.c	1996/07/23 22:06:47	1.1
> --- regexec.c	1997/02/10 06:31:18
> ***************
> *** 16,23 ****
>   #include "utils.h"
>   #include "regex2.h"
>   
> - static int nope = 0;		/* for use in asserts; shuts lint up */
> - 
>   /* macros for manipulating states, small version */
>   #define	states	long
>   #define	states1	states		/* for later use in regexec() decision */
> --- 16,21 ----

There are a bunch of assert(nope)s.  But they don't break when you take
out that.  Haven't looked at that really.

There are also other errors that I get on FreeBSD.  The register not
at beginning of declaration are easy to fix, haven't looked at the rest.

engine.c: In function `smatcher':
In file included from regexec.c:44:
engine.c:78: warning: `register' is not at beginning of declaration
engine.c:79: warning: `register' is not at beginning of declaration
engine.c: In function `lmatcher':
In file included from regexec.c:93:
engine.c:78: warning: `register' is not at beginning of declaration
engine.c:79: warning: `register' is not at beginning of declaration
sh ./mkh  -p regerror.c >regerror.ih
cc -I. -DPOSIX_MISTAKE  -Wall -c regerror.c
cc -I. -DPOSIX_MISTAKE  -Wall -c regfree.c
cc -I. -DPOSIX_MISTAKE  -Wall -c split.c
sh ./mkh  -p debug.c >debug.ih
cc -I. -DPOSIX_MISTAKE  -Wall -c debug.c
debug.c: In function `s_print':
debug.c:219: warning: int format, long int arg (arg 3)
debug.c:219: warning: int format, long int arg (arg 4)
sh ./mkh  -p main.c >main.ih
cc -I. -DPOSIX_MISTAKE  -Wall -c main.c
main.c:27: warning: return-type defaults to `int'
main.c: In function `main':
main.c:44: warning: implicit declaration of function `getopt'
main.c:53: warning: implicit declaration of function `atoi'
main.c:107: warning: field width is not type int (arg 2)
main.c: In function `efind':
main.c:502: warning: unused variable `n'



Mime
View raw message