httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@znep.com>
Subject Re: cvs commit: apache/support suexec.c
Date Wed, 12 Feb 1997 00:32:16 GMT
What about increasing the AP_MAXPATH fallthrough to >256?

256 is dangerous on systems w/o either PATH_MAX or MAXPATHLEN.

On Tue, 11 Feb 1997, Randy Terbush wrote:

> randy       97/02/11 09:57:22
> 
>   Modified:    support   suexec.c
>   Log:
>   Correct an allocation mistake pointed out by Marc.
>   
>   Revision  Changes    Path
>   1.16      +1 -1      apache/support/suexec.c
>   
>   Index: suexec.c
>   ===================================================================
>   RCS file: /export/home/cvs/apache/support/suexec.c,v
>   retrieving revision 1.15
>   retrieving revision 1.16
>   diff -C3 -r1.15 -r1.16
>   *** suexec.c	1997/02/10 14:05:34	1.15
>   --- suexec.c	1997/02/11 17:57:20	1.16
>   ***************
>   *** 181,187 ****
>         int idx;
>         
>     
>   !     if ((cleanenv = (char **)calloc(AP_ENVBUF, AP_ENVBUF * (sizeof(char *)))) ==
NULL) {
>     	log_err("failed to malloc env mem\n");
>     	exit(120);
>         }
>   --- 181,187 ----
>         int idx;
>         
>     
>   !     if ((cleanenv = (char **)calloc(AP_ENVBUF, sizeof(char *))) == NULL) {
>     	log_err("failed to malloc env mem\n");
>     	exit(120);
>         }
>   
>   
>   
> 


Mime
View raw message