httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@znep.com>
Subject Re: [PATCH] (PR#130) mod_imap infinite loop fix
Date Sun, 09 Feb 1997 18:34:50 GMT
On Sun, 9 Feb 1997, Roy T. Fielding wrote:

> >You would rather have it go into an infinte loop when that happens than
> >give an incorrect result?  
> 
> Yes, if the choice is between changing the definition of base and
> telling the user to RTFM.  Of course, I would prefer a fix that just
> avoided the problem without changing the definition of base.
> 
> >To agree with the HTML idea of the BASE element you would have to do too
> >many changes for my liking.  I have patches to either make the base always
> >behave like a directory or to just fix the loop and have the a base of
> >'foo' plus a '1.html' giving 'foo1.html'.  One of them should be
> >implemented; neither break current behavior because current behavior is an
> >infinite loop.
> 
> A properly made imagemap file will have a proper base URL. The change
> you propose would break a proper imagemap file in order to satisfy a
> broken imagemap file.  Replacing one bug with another is not good.

I am not changing the definition of ANYTHING.  My change does absolutely
NOTHING to "proper" imagemap files as parsed by the current code simply
because the only case that it affects DOES NOT WORK NOW and leaves the
server in an infinite loop.

If the input isn't a valid base, we can do whatever we WANT with it.  I
don't understand your problem.  I am not replacing one bug with another, I
am simply removing one bug which is very annoying because it causes the
server to go into an infinite loop and not fixing other bugs which simply
don't parse things as they should.


Mime
View raw message