httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <>
Subject Re: [PATCH] (PR#130) mod_imap infinite loop fix
Date Sun, 09 Feb 1997 08:39:04 GMT
On Sat, 8 Feb 1997, Roy T. Fielding wrote:

> >This patch fixes PR#130 by assuming that any 'base' in an imagemap
> >file refers to a directory.  The only incompatible behavior it can 
> >cause is that now the server won't go into an infinite loop when
> >it gets such a request.  It is arguable that it should treat a base
> >without a '/' as a file to which the rest should be appended, but
> >I think this way makes more sense.
> I don't think so.  The base is supposed to be a base URL, which means
> we should use the relative URL resolution process to do the combination.
> I'd rather leave it buggy than change the feature's purpose.  If we
> are going to fix it, then a utility absolute(base,relative) function
> should be created to do it right.

You would rather have it go into an infinte loop when that happens than
give an incorrect result?  

To agree with the HTML idea of the BASE element you would have to do too
many changes for my liking.  I have patches to either make the base always
behave like a directory or to just fix the loop and have the a base of
'foo' plus a '1.html' giving 'foo1.html'.  One of them should be
implemented; neither break current behavior because current behavior is an
infinite loop.

mod_imap needs a lot of cleanup, but I don't think that should happen
before 1.2.

View raw message