httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: [PATCH] Don't propagate EXTRA_CFLAGS to regex library
Date Tue, 11 Feb 1997 09:32:48 GMT
Roy T. Fielding wrote:
> 
> Since we aren't going to fix the warnings, this is the easiest way
> to make them go away without risking breakage.

Isn't it rather dangerous to assume that EXTRA_CFLAGS will only be used for
warnings?

Cheers,

Ben.

> 
> .....Roy
> 
> Index: Makefile.tmpl
> ===================================================================
> RCS file: /export/home/cvs/apache/src/Makefile.tmpl,v
> retrieving revision 1.40
> diff -c -r1.40 Makefile.tmpl
> *** Makefile.tmpl	1997/01/26 01:59:03	1.40
> --- Makefile.tmpl	1997/02/10 21:29:36
> ***************
> *** 4,9 ****
> --- 4,10 ----
>   # by the configure script to make the actual Makefile.
>   
>   CFLAGS=$(OPTIM) $(CFLAGS1) $(EXTRA_CFLAGS)
> + CFLAGS_REGEX=$(OPTIM) $(CFLAGS1)
>   LIBS=$(EXTRA_LIBS) $(LIBS1)
>   INCLUDES=$(INCLUDES1) $(EXTRA_INCLUDES)
>   LFLAGS=$(LFLAGS1) $(EXTRA_LFLAGS)
> ***************
> *** 29,35 ****
>   	$(CC) $(LFLAGS)  -o httpd $(OBJS) $(REGLIB) $(LIBS)
>   
>   regex/libregex.a:
> ! 	(cd regex; $(MAKE) lib CC=$(CC) AUX_CFLAGS='$(CFLAGS)' RANLIB='$(RANLIB)')
>   
>   modules/proxy/libproxy.a:
>   	(cd modules; \
> --- 30,36 ----
>   	$(CC) $(LFLAGS)  -o httpd $(OBJS) $(REGLIB) $(LIBS)
>   
>   regex/libregex.a:
> ! 	(cd regex; $(MAKE) lib CC=$(CC) AUX_CFLAGS='$(CFLAGS_REGEX)' RANLIB='$(RANLIB)')
>   
>   modules/proxy/libproxy.a:
>   	(cd modules; \

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message