httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@kiwi.ICS.UCI.EDU>
Subject Re: [PATCH] (PR#130) mod_imap infinite loop fix
Date Mon, 10 Feb 1997 19:18:34 GMT
>Have you looked at the code and tried the example I gave?


>Do you
>understand that right now the code assumes that any base URL not ending in
>a slash is a directory, only it just assumes that without checking to be
>sure that is a valid assumption?

No, it doesn't.  If the base URL contains at least one single-slash,
it will work fine (unless it triggers one of the six or seven other
bugs in the imap_url routine).  The loop only happens if there are no
slashes in the base URL, which would not be the case if the user RTFM. 
Yes, we should fix it, but fix it right.

>Would you be happy if it simply aborted
>and said "hey you moron, this module is broken" if it got that?


>Are you saying we should redo the parsing code in mod_imap before 1.2?  It
>is not acceptable to leave a known bug that causes an infinite loop simply
>because a fix to that problem doesn't fix everything else in the module.

Yes, we should redo the parsing code in mod_imap before 1.2.
It would probably be easier than finishing this argument.


View raw message