httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@kiwi.ICS.UCI.EDU>
Subject Re: [PATCH] (PR#130) mod_imap infinite loop fix
Date Mon, 10 Feb 1997 11:10:56 GMT
>Actually, 'base' was not intended just to be a URL. It does however
>only make sense to deal with the directory it references IMO. Marc's
>fix does follow with the feature's purpose be it right or wrong.

Wait a minute, now I'm completely confused.  The code says it is
a base URL, the documentation says it is a base URL, it is currently
being parsed as a base URL (well, kind of -- it is nowhere close to
being compliant with RFC 1808), but somehow it is supposed to be a directory?

We can't have it both ways.  Either it is a URL or a directory, since the
two have distinctly different meanings without a trailing slash.  Given
that the code says that it can be set to the map URL, the referer URL,
or a configured URL, it would seem to me that it isn't a directory.

The correct fix to the problem reported is to replace the existing, buggy
imap_url() routine with a proper utility function that performs
relative -> absolute conversion.  Until then, the existing bug is better
than assuming that any base URL not ending in a slash is supposed to be a


View raw message