httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: [PATCH] SSI handling of braces fix
Date Sun, 09 Feb 1997 07:57:27 GMT
Howard Fear wrote:
> 
> 
> Ben Laurie writes:
> > >   * escaping '{''s in SSI has changed.  Bug?
> > >     Message-ID: <Pine.BSF.3.91.970203113400.925C-100000@localhost.imdb.com>
> > 
> > This (untested) patch should fix the problem:
> 
> Ummm, I don't think so.  Actually, it works as designed.  mod_include
> now does variable substitution so the user needs to escape the '$' to
> pass it along to the shell.  Escaping the '{' works by accident - 
> it causes the SSI variable to be terminated at just '$'.  Since this
> isn't a valid variable, it gets passed along instead of being
> substituted.

Exactly. And the same would happen if my patch were applied. However, if
may patch is not applied, what happens is that ${A:B} gets $A substituted for
the first part. Which is wrong. All my patch does is to force everything up to
the '}' to be taken as the variable name, which means that if it is actually
something more complex, it won't match a variable and will therefore be left
intact.

Cheers,

Ben.

> 
> There is a small change that I think I can make which will make the
> originator's specific example work without change because of its use
> of ':='.  I'll try it tomorrow and send the results.
> 
> --
> Howard Fear      I'm just a country perl hacker Jim.        hsf@pageplus.com
>                     http://www.pageplus.com/~hsf/           hsf@redcape.com

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message