httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: [PATCH] correct irix 5.3 gcc -Wall warnings
Date Mon, 17 Feb 1997 00:04:05 GMT
Marc Slemko wrote:
> 
> On Mon, 10 Feb 1997, Dean Gaudet wrote:
> 
> > This is interesting.  IRIX FD_ZERO uses bzero and requires you to include
> > <bstring.h> to get the prototype.  Weirdos.
> > 
> > Also, killpg() is part of the IRIX -D_BSD_COMPAT functionality, and since
> > the rest of apache doesn't use -D_BSD_COMPAT it probably shouldn't use
> > killpg()... I fear some sort of compatibility problem.
> 
> I was about to commit this, but was trying to figure out what to say in
> the PORTING file.  "Define if the OS has bstring.h"?  No, since lots of
> OSes have bstring.h but don't need it included.  "Define if the OS needs
> bstring.h for FD_ZERO"?  Well... sure, but that doesn't really fit with
> the HAVE_BSTRING_H bit. 

How about FD_ZERO_NEEDS_BSTRING_H :)

> 
> Comments?
> 
> > 
> > Patch included.
> > 
> > Dean
> > 
> > Index: buff.c
> > ===================================================================
> > RCS file: /hot/repository/apache/src/buff.c,v
> > retrieving revision 1.5
> > diff -c -3 -r1.5 buff.c
> > *** buff.c	1997/02/11 02:02:41	1.5
> > --- buff.c	1997/02/11 02:51:33
> > ***************
> > *** 65,70 ****
> > --- 65,74 ----
> >   #include "alloc.h"
> >   #include "buff.h"
> >   
> > + #ifdef HAVE_BSTRING_H
> > + #include <bstring.h>		/* for IRIX, FD_SET calls bzero() */
> > + #endif
> > + 
> >   #define DEFAULT_BUFSIZE (4096)
> >   
> >   /*
> > Index: conf.h
> > ===================================================================
> > RCS file: /hot/repository/apache/src/conf.h,v
> > retrieving revision 1.6
> > diff -c -3 -r1.6 conf.h
> > *** conf.h	1997/02/11 02:02:42	1.6
> > --- conf.h	1997/02/11 02:50:13
> > ***************
> > *** 102,114 ****
> >   
> >   #elif defined(IRIX)
> >   #undef HAVE_GMTOFF
> > ! #undef NO_KILLPG
> >   #undef NO_SETSID
> >   #define JMP_BUF sigjmp_buf
> >   #define USE_FCNTL_SERIALIZED_ACCEPT
> >   #define HAVE_SHMGET
> >   #define HAVE_CRYPT_H
> >   #define NO_LONG_DOUBLE
> >   
> >   #elif defined(HIUX)
> >   #define HAVE_SYS_RESOURCE_H
> > --- 102,117 ----
> >   
> >   #elif defined(IRIX)
> >   #undef HAVE_GMTOFF
> > ! /* IRIX has killpg, but it's only in _BSD_COMPAT, so don't use it in case
> > !  * there's some weird conflict with non-BSD signals */
> > ! #define NO_KILLPG
> >   #undef NO_SETSID
> >   #define JMP_BUF sigjmp_buf
> >   #define USE_FCNTL_SERIALIZED_ACCEPT
> >   #define HAVE_SHMGET
> >   #define HAVE_CRYPT_H
> >   #define NO_LONG_DOUBLE
> > + #define HAVE_BSTRING_H
> >   
> >   #elif defined(HIUX)
> >   #define HAVE_SYS_RESOURCE_H
> > Index: http_main.c
> > ===================================================================
> > RCS file: /hot/repository/apache/src/http_main.c,v
> > retrieving revision 1.29
> > diff -c -3 -r1.29 http_main.c
> > *** http_main.c	1997/02/11 02:40:40	1.29
> > --- http_main.c	1997/02/11 02:46:40
> > ***************
> > *** 100,105 ****
> > --- 100,109 ----
> >   #endif
> >   #include <netinet/tcp.h>
> >   
> > + #ifdef HAVE_BSTRING_H
> > + #include <bstring.h>		/* for IRIX, FD_SET calls bzero() */
> > + #endif
> > + 
> >   #include "explain.h"
> >   
> >   #if !defined(max)
> > 
> > 
> 


-- 
====================================================================
      Jim Jagielski            |       jaguNET Access Services
     jim@jaguNET.com           |       http://www.jaguNET.com/
                  "Not the Craw... the CRAW!"

Mime
View raw message