Received: by taz.hyperreal.com (8.8.4/V2.0) id LAA04252; Sun, 26 Jan 1997 11:59:20 -0800 (PST) Received: from eat.organic.com by taz.hyperreal.com (8.8.4/V2.0) with ESMTP id LAA04246; Sun, 26 Jan 1997 11:59:16 -0800 (PST) Received: from localhost (brian@localhost) by eat.organic.com (8.8.3/8.6.12) with SMTP id MAA23472 for ; Sun, 26 Jan 1997 12:00:07 -0800 (PST) Date: Sun, 26 Jan 1997 12:00:07 -0800 (PST) From: Brian Behlendorf To: new-httpd@hyperreal.com Subject: Re: [PATCH] allow whitespace after comma in mod_imap (tr#106) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@hyperreal.com +1. On Fri, 24 Jan 1997, Marc Slemko wrote: > The below patch allows for whitespace after the ',' in an imagemap file. > before: > rect foo.html 0,0 310,100 > > after, you could also use: > rect foo.html 0, 0 310, 100 > > It is the subject of tr#106 and can be a little annoying to find. If > people like it, I don't care if it goes in before b5 (why not?) b6 > (sure...) or even after 1.2 (no rush). > > > Index: mod_imap.c > =================================================================== > RCS file: /export/home/cvs/apache/src/mod_imap.c,v > retrieving revision 1.16 > diff -c -r1.16 mod_imap.c > *** 1.16 1997/01/20 09:02:54 > --- mod_imap.c 1997/01/25 01:16:40 > *************** > *** 720,726 **** > > vertex = 0; > while ( vertex < MAXVERTS && > ! sscanf(string_pos, "%lf,%lf", > &pointarray[vertex][X], &pointarray[vertex][Y]) == 2) > { > /* Now skip what we just read... we can't use ANSIism %n */ > --- 720,726 ---- > > vertex = 0; > while ( vertex < MAXVERTS && > ! sscanf(string_pos, "%lf, %lf", > &pointarray[vertex][X], &pointarray[vertex][Y]) == 2) > { > /* Now skip what we just read... we can't use ANSIism %n */ > *************** > *** 729,734 **** > --- 729,736 ---- > while(isdigit(*string_pos)) /* and the 1st number */ > string_pos++; > string_pos++; /* skip the ',' */ > + while(isspace(*string_pos)) /* past any more whitespace */ > + string_pos++; > while(isdigit(*string_pos)) /* 2nd number */ > string_pos++; > vertex++; > > > --=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-- brian@organic.com www.apache.org hyperreal.com http://www.organic.com/JOBS