httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] avoid bflush() when pipelining
Date Sat, 25 Jan 1997 10:13:00 GMT
On Sat, 25 Jan 1997, Alexei Kosut wrote:
> Patch looks good. +1. A question, though: I notice a bflush() in
> send_fd_length() in http_protocol.c. That looks a bit
> suspicious - do we even need it?

I would say no.  The only case that I'd worry about is the use of send_fd
in mod_cgi... but I'm pretty sure it's fine 'cause it falls back to the
main loop pretty soon afterwards and the correct bflush() behaviour is
dealt with there. 

Dean

Index: http_protocol.c
===================================================================
RCS file: /export/home/cvs/apache/src/http_protocol.c,v
retrieving revision 1.91
diff -c -3 -r1.91 http_protocol.c
*** http_protocol.c	1997/01/20 04:28:09	1.91
--- http_protocol.c	1997/01/25 10:12:23
***************
*** 1371,1378 ****
  	    o+=w;
          }
      }
- 
-     if (length > 0) bflush(c->client);
      
      SET_BYTES_SENT(r);
      return total_bytes_sent;
--- 1371,1376 ----


Mime
View raw message