httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexei Kosut <>
Subject Re: [PATCH] must flush for CRLFs after POSTs
Date Tue, 28 Jan 1997 14:57:08 GMT
On Tue, 28 Jan 1997, Ben Laurie wrote:

> > On the one time in a thousand that that happens, then the read buffer will be
> > flushed anyway because it will look as though there are no more requests
> > to come.
> You've lost me. Surely we wait for the keepalive timeout period for a new
> request?

No, David's right. The issue we're talking about here is when to
flush. Currently, we don't flush directly after the request if there's
data to be read. If the CRLF isn't there to be seen at the end of a
request yet, the server will flush the last bits out, and everyone
will be happy. The CRLF will then be seen as whitespace at the
beginning of the next request (which Apache gracefully supports),
rather than at the end of the old one.

But I'm not sure I like that solution. For one thing, mod_cgi is
definitely the wrong place to put it, since POSTs can come
anywhere. It would have to be done as part of the http_main loop that
controls keepalives. And there's little difference between putting it
there and in read_request(), as Dean as suggested.

Alexei Kosut <>      The Apache HTTP Server

View raw message