httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@kiwi.ICS.UCI.EDU>
Subject [PATCH] silence regex warnings
Date Thu, 30 Jan 1997 06:16:49 GMT
>   * warnings in regex
>        Status: Roy would like to see this fixed since it makes Apache
>                a mess on Solaris when using -Wall.  Roy will make patch.

I spent a couple hours trying to fix the warnings directly, but the vast
majority are created by side-effect macros that can't be fixed without
risking total disaster.  Since none of the warnings are significant,
I've given up and recommend the following patch instead.  It would probably
be better to define a special -DREGEX_CFLAGS in Configuration, but this
works for me.  It won't work for compilers that need something defined
in EXTRA_CFLAGS, so a more portable solution would be welcome from those
who regularly mess with the Configure stuff.  OTOH, this method prevents
Apache-specific defines from interfering with regex defines.


Index: Makefile.tmpl
RCS file: /export/home/cvs/apache/src/Makefile.tmpl,v
retrieving revision 1.40
diff -c -r1.40 Makefile.tmpl
*** Makefile.tmpl	1997/01/26 01:59:03	1.40
--- Makefile.tmpl	1997/01/30 06:08:29
*** 29,35 ****
  	$(CC) $(LFLAGS)  -o httpd $(OBJS) $(REGLIB) $(LIBS)
! 	(cd regex; $(MAKE) lib CC=$(CC) AUX_CFLAGS='$(CFLAGS)' RANLIB='$(RANLIB)')
  	(cd modules; \
--- 29,35 ----
  	$(CC) $(LFLAGS)  -o httpd $(OBJS) $(REGLIB) $(LIBS)
! 	(cd regex; $(MAKE) lib CC=$(CC) AUX_CFLAGS='$(OPTIM)' RANLIB='$(RANLIB)')
  	(cd modules; \

View raw message