httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@liege.ICS.UCI.EDU>
Subject Re: Hold the Presses! Possible problem in 1.2b5
Date Sun, 26 Jan 1997 20:40:50 GMT
> I've found that the changes in the patch submitted by Roy which
> changed the loop in child_main() around the accept fails to
> serve a request on my FreeBSD 2.1.6 server.
> 
> However, it seems to work fine on a FreeBSD 2.2 machine.
> 
> [Sun Jan 26 14:19:21 1997] accept: (client socket): Undefined error: 0
> 
> Looks like this is the code in question. Reversing that patch solves
> the problem.
> 
>                 do {
>                     clen = sizeof(sa_client);
>                     csd  = accept(sd, &sa_client, &clen);
>                 } while (csd < 0 && errno == EINTR);
>                 if (csd < 0) break;
> 		log_unixerr("accept", "(client socket)", NULL, server_conf);

Shit, try changing the last (csd < 0) to (csd > 0) break;

.....Roy

Mime
View raw message