httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: apache/src/modules/proxy proxy_cache.c proxy_ftp.c proxy_http.c proxy_util.c
Date Mon, 20 Jan 1997 23:50:47 GMT
Alexei Kosut wrote:
> 
> On Sun, 19 Jan 1997, Jim Jagielski wrote:
> 
> The top of util_snprintf.h should be in conf.h anyway (IMHO), not
> util_snprintf.c. In other words, conf.h should contain (near the
> bottom):
> 
> #ifdef HAVE_SNPRINTF
> #define ap_snprintf     snprintf
> #define ap_vsnprintf    vsnprintf
> #else
> int ap_snprintf(char *buf, size_t len, const char *format,...);
> #endif
> 
> #ifdef HAVE_CVT
> #define ap_ecvt ecvt
> #define ap_fcvt fcvt
> #define ap_gcvt gcvt
> #endif
> 
> util_snprintf.c should then #include "conf.h". Regardless, it should:
> this allows conf.h to define HAVE_SNPRINTF and HAVE_CVT for various
> OSes. Otherwise, there is no way to define these other than in
> Configuration, and there's no point to put it there: this is a per-OS
> issue and has nothing to do with the Makefile or whatnot (like regex
> libraries).
> 

If util_snprintf.c includes conf.h then it doesn't matter where the
above stuff goes. Although it is an oversight that ap_snprintf()
isn't prototyped.
-- 
====================================================================
      Jim Jagielski            |       jaguNET Access Services
     jim@jaguNET.com           |       http://www.jaguNET.com/
                  "Not the Craw... the CRAW!"

Mime
View raw message