httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sameer <sam...@c2.net>
Subject Re: comment on HARD_SERVER_LIMIT in httpd.h
Date Sun, 05 Jan 1997 19:45:11 GMT
+1
> Since no one has followed up on this, perhaps a patch will make people see
> what a silly little thing this is that can be fixed in 2 seconds. 
> 
> Index: httpd.h
> ===================================================================
> RCS file: /home/marcs/archive/apache/cvs/apache/src/httpd.h,v
> retrieving revision 1.78
> diff -c -r1.78 httpd.h
> *** httpd.h	1997/01/01 18:10:23	1.78
> --- httpd.h	1997/01/05 17:50:38
> ***************
> *** 217,225 ****
>    * We keep a hard maximum number of servers, for two reasons --- first off,
>    * in case something goes seriously wrong, we want to stop the fork bomb
>    * short of actually crashing the machine we're running on by filling some
> !  * kernel table (I was originally going to make this 256, but it turns out
> !  * that that would actually fill the process table on reasonably configured
> !  * machines).  Secondly, it keeps the size of the scoreboard file small
>    * enough that we can read the whole thing without worrying too much about
>    * the overhead.
>    */
> --- 218,224 ----
>    * We keep a hard maximum number of servers, for two reasons --- first off,
>    * in case something goes seriously wrong, we want to stop the fork bomb
>    * short of actually crashing the machine we're running on by filling some
> !  * kernel table.  Secondly, it keeps the size of the scoreboard file small
>    * enough that we can read the whole thing without worrying too much about
>    * the overhead.
>    */
> 
> On Mon, 30 Dec 1996, Marc Slemko wrote:
> 
> > src/httpd.h still reads:
> > 
> > /* Limit on the total --- clients will be locked out if more servers than
> >  * this are needed.  It is intended solely to keep the server from crashing
> >  * when things get out of hand.
> >  *
> >  * We keep a hard maximum number of servers, for two reasons --- first off,
> >  * in case something goes seriously wrong, we want to stop the fork bomb
> >  * short of actually crashing the machine we're running on by filling some
> >  * kernel table (I was originally going to make this 256, but it turns out
> >  * that that would actually fill the process table on reasonably configured
> >  * machines).  Secondly, it keeps the size of the scoreboard file small
> >  * enough that we can read the whole thing without worrying too much about
> >  * the overhead.
> >  */
> > #define HARD_SERVER_LIMIT 256
> > 
> > HARD_SERVER_LIMIT was bumped up a while ago, but the note about it
> > not being 256 wasn't removed/modified.
> > 
> > 
> 


-- 
Sameer Parekh					Voice:   510-986-8770
President					FAX:     510-986-8777
C2Net 		    C2Net is having a party: http://www.c2.net/party/
http://www.c2.net/				sameer@c2.net

Mime
View raw message