Subject: Re: r->status = new->status;
To: new-httpd@hyperreal.com
Date: Tue, 10 Dec 1996 22:31:48 +0000 (GMT)
From: Ben Laurie <ben@gonzo.ben.algroup.co.uk>
In-Reply-To: <199612102245.WAA13606> from "Rob Hartill" at Dec 10,
 96 10:45:17 pm
Reply-To: ben@algroup.co.uk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-ID: <9612102231.aa20705@gonzo.ben.algroup.co.uk>
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@hyperreal.com

Rob Hartill wrote:
> 
> 
> I didn't get any response on this last time, so here goes again..
> 
> A last minute 1.1 -> 1.2b1 patch from Ben (which I +1'ed) needs to be
> removed.
> 
> The reason for having it was to get internally redirected requests
> logged with the final status value instead of the original one (e.g.
> after ErrorDocument has come to the rescue and sent out a 200 OK).
> 
> The last minute change breaks mod_log_config.c, which if you check,
> has options to log the final status anyway. So this "fix" is redundant
> and it hardcodes Apache's behaviour and prevents reconfiguration.
> 
> If it is important that Apache logs the same status as the client sees
> (which is reasonable considering the complexity^H^H^H^H^Hsophistication
> of Apache configs these days - lots of internal redirects doing lots of
> tricks), then all that's needed is to adjust the default log format string.
> 
> This is a new bug IMO.  Vote for the patches spearately if necessary.
> 
> 
> Index: http_request.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/http_request.c,v
> retrieving revision 1.1
> diff -c -r1.1 http_request.c
> *** http_request.c      1996/12/10 05:02:47     1.1
> --- http_request.c      1996/12/10 22:28:26
> ***************
> *** 1008,1018 ****
>   {
>       request_rec *new = internal_internal_redirect(new_uri, r);
>       process_request_internal (new);
> - 
> -     /* Promote the new redirected request result into r for logging.
> -      * We may need to promote other things, but this one is known.
> -      */
> -     r->status = new->status;
>   }
>   
>   /* This function is designed for things like actions or CGI scripts, when
> --- 1008,1013 ----
> 
> 
> 
> 
> Index: mod_log_config.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/mod_log_config.c,v
> retrieving revision 1.1
> diff -c -r1.1 mod_log_config.c
> *** mod_log_config.c    1996/12/10 05:03:12     1.1
> --- mod_log_config.c    1996/12/10 22:34:53
> ***************
> *** 155,161 ****
>    *
>    * --- rst */
>   
> ! #define DEFAULT_LOG_FORMAT "%h %l %u %t \"%r\" %s %b"
>   
>   #include "httpd.h"
>   #include "http_config.h"
> --- 155,161 ----
>    *
>    * --- rst */
>   
> ! #define DEFAULT_LOG_FORMAT "%h %l %u %t \"%r\" %>s %b"
>   
>   #include "httpd.h"
>   #include "http_config.h"
> 

+1

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author