Message-Id: <199612231504.JAA24858@sierra.zyzzyva.com>
To: ben@algroup.co.uk, new-httpd@hyperreal.com
Subject: Re: suexec fixes 
In-reply-to: ben's message of Mon, 23 Dec 1996 08:40:22 +0000.
         <9612230840.aa29062@gonzo.ben.algroup.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 23 Dec 1996 09:04:59 -0600
From: Randy Terbush <randy@zyzzyva.com>
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@hyperreal.com

> Randy Terbush wrote:
> > 
> > > > 3.  CGI command lines paramters problems
> > > > 
> > > > 	Code in call_exec() was not properly passing arguments in argv[]
> > > > 	if you want to pass arguments via '+' separated URL.
> > > > 	Taking the hint from Jake Buchholz I have changed create_argv()
> > > > 	to accept a variable number of parameters. This is the only
> > > > 	change to the server code and is included first in the
> > > > 	patch below.
> > > 
> > > Perhaps I'm being stupid ... I completely fail to see the point of this...
> > > 
> > > Cheers,
> > > 
> > > Ben.
> > 
> > 
> > I tend to agree, which is probably why I didn't implement it the first pass.
> > Some people apparently pass arguments to their CGI via argv[]. This does
> > kind of go against what CGI is all about, but we have apparently supported
> > it in the past for non-suexec stuff.
> 
> This is not what I mean. You seem to have made create_argv() take a varargs,
> then _always_ hand it one arg. Why?

?? commas in there...

called with 7:
create_argv(r, SUEXEC_BIN, execuser, gr->gr_name, argv0, r->args, NULL)

called with 4:
create_argv(r, argv0, r->args, NULL)

char **create_argv(request_rec *r, char *av0, ...)

Am I missing an obvious mistake?