From: sameer <sameer@c2.net>
Message-Id: <199612172238.OAA18531@atropos.c2.org>
Subject: Re: cvs commit: apache/src CHANGES http_core.c
To: new-httpd@hyperreal.com
Date: Tue, 17 Dec 1996 14:38:02 -0800 (PST)
Cc: apache-cvs@hyperreal.com
In-Reply-To: <199612172030.MAA17954@taz.hyperreal.com> from "Randy Terbush" at
 Dec 17, 96 12:30:50 pm
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@hyperreal.com

I actually don't recall reporting to the list that I did test it. It
*does* work, I tested it late last night. Just a minor nit because I
hadn't actually +1'd it until just now.

> 
> randy       96/12/17 12:30:49
> 
>   Modified:    src       CHANGES http_core.c
>   Log:
>   Initialize listen_rec->used in set_listener() to fix a dereference
>   problem when restarting the server.
>   Reviewed by: Sameer Parekh, Randy Terbush
>   Submitted by: Ben Laurie
>   
>   Revision  Changes    Path
>   1.88      +6 -0      apache/src/CHANGES
>   
>   Index: CHANGES
>   ===================================================================
>   RCS file: /export/home/cvs/apache/src/CHANGES,v
>   retrieving revision 1.87
>   retrieving revision 1.88
>   diff -C3 -r1.87 -r1.88
>   *** CHANGES	1996/12/15 22:06:53	1.87
>   --- CHANGES	1996/12/17 20:30:46	1.88
>   ***************
>   *** 1,5 ****
>   --- 1,11 ----
>     Changes with Apache 1.2b3:
>     
>   +   *) Add the ability to pass different Makefile.tmpl files to Configure
>   +      using the -make flag.
>   + 
>   +   *) Fix coredump triggered when sending a SIGHUP to the server caused
>   +      by a dereference of an unitialized pointer in the listen_rec.
>   + 
>       *) Add FILEPATH_INFO variable to CGI environment, which is equal to
>          PATH_INFO from previous versions of Apache (in certain situations,
>          Apache 1.2's PATH_INFO will be different than 1.1's). [Alexei Kosut]
>   
>   
>   
>   1.53      +1 -0      apache/src/http_core.c
>   
>   Index: http_core.c
>   ===================================================================
>   RCS file: /export/home/cvs/apache/src/http_core.c,v
>   retrieving revision 1.52
>   retrieving revision 1.53
>   diff -C3 -r1.52 -r1.53
>   *** http_core.c	1996/12/06 21:51:32	1.52
>   --- http_core.c	1996/12/17 20:30:46	1.53
>   ***************
>   *** 1084,1089 ****
>   --- 1084,1090 ----
>     	return "Port must be numeric";
>         new->local_addr.sin_port = htons(port);
>         new->fd = -1;
>   +     new->used = 0;
>         new->next = listeners;
>         listeners = new;
>         return NULL;
>   
>   
>   
> 


-- 
Sameer Parekh					Voice:   510-986-8770
President					FAX:     510-986-8777
C2Net
http://www.c2.net/				sameer@c2.net