httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@organic.com>
Subject Re: rwrite and mod_perl
Date Thu, 12 Dec 1996 00:29:36 GMT

It's been committed.  Someone want to write about it in CHANGES?  

	Brian

On Wed, 11 Dec 1996, Randy Terbush wrote:
> +1
> 
> I agree that this seems harmless enough. I would like to see
> the perl module become a bit more approachable. From following
> what has been done with it over the past few months, I think it
> offers some endless capabilities to Apache.
> 
> 
> > Doug MacEachern wrote:
> > 
> > >Here is my original suggestion, I just used the other r* functions as
> > >a model.
> > >
> > >-Doug
> > >
> > >int rwrite(const void *buf, int nbyte, request_rec *r)
> > >{
> > >    int n;
> > >    if (r->connection->aborted) return EOF;
> > >    n=bwrite(r->connection->client, buf, nbyte);
> > >    SET_BYTES_SENT(r);
> > >    return n;
> > >}
> > 
> > 
> > Looks reasonable. Adding this won't affect anything else so  +1
> > on this as a speed-bump bug fix for module authors.
> > 
> > 
> > btw, don't forget this if it gets committed:
> > 
> > Index: http_protocol.h
> > ===================================================================
> > RCS file: /export/home/cvs/apache/src/http_protocol.h,v
> > retrieving revision 1.1
> > diff -c -r1.1 http_protocol.h
> > *** http_protocol.h	1996/12/10 05:02:46	1.1
> > --- http_protocol.h	1996/12/11 17:54:20
> > ***************
> > *** 112,117 ****
> > --- 112,118 ----
> >        
> >   int rputc (int c, request_rec *r);     
> >   int rputs(const char *str, request_rec *r);
> > + int rwrite(const void *buf, int nbyte, request_rec *r);
> >   int rvputs(request_rec *r, ...);
> >   int rprintf(request_rec *r,const char *fmt,...);
> >        
> > 
> 
> 
> 
> 
> 

--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com  www.apache.org  hyperreal.com  http://www.organic.com/JOBS


Mime
View raw message