httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@organic.com>
Subject Re: escape_uri bug fix never applied
Date Sun, 01 Dec 1996 23:29:54 GMT
On Sun, 1 Dec 1996, Ben Laurie wrote:
> Brian Behlendorf wrote:
> > 
> > Huh?  Escaping to make something safe to the OS command line and escaping to
> > make safe for URL embedding seem like two separate actions, which may have the
> > same algorithm or may not.  Why collapse them?  
> 
> Errr ... escape_shell_cmd() is the one that does command lines. And it has a
> completely different algorithm.
> 
> os_escape_path() was originally written as a replacement for escape_uri(). It
> wasn't used globally in the first place, because it lacked the "partial"
> argument. I fixed that a long time ago, but didn't follow up with escape_uri()
> removal.

Ah, okay.  +1 to Roy's most recent patch then.  

	Brian

--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com  www.apache.org  hyperreal.com  http://www.organic.com/JOBS


Mime
View raw message