httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@organic.com>
Subject Re: escape_uri bug fix never applied
Date Sun, 01 Dec 1996 23:10:05 GMT
On Sun, 1 Dec 1996, Rob Hartill wrote:
> Randy Terbush wrote:
> 
> 
> >I guess we are still on hold waiting for commitment of a couple of patches.
> >What else are we waiting on Rob?
> 
> Roy has 1 uncommitted (AFAIK) patch that nuked escape_uri (replaced by a
> #define). It has Roy and my vote.

I have my doubts; the logic was

(Ben Laurie wrote:)
> OK. The main reasons were that path escaping was platform dependent, at least
> in theory, and that escape_uri() was broken.

(Roy Fielding wrote:)
> crikey, then escape_uri() should have been removed and replaced with
> a #define macro for os_escape_path.  I'll do that.

Huh?  Escaping to make something safe to the OS command line and escaping to
make safe for URL embedding seem like two separate actions, which may have the
same algorithm or may not.  Why collapse them?  

	Brian

--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com  www.apache.org  hyperreal.com  http://www.organic.com/JOBS


Mime
View raw message