httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: cvs commit: apache/src mod_expires.c
Date Wed, 04 Dec 1996 21:54:26 GMT
Roy T. Fielding wrote:
> 
> >   --- 278,284 ----
> >         while ( word[0] ) {
> >     	/* <num>
> >     	 */
> >   ! 	if ( isdigit(word[0]) != NULL ) {
> >     	    num = atoi( word );
> >     	} else {
> >                 return pstrcat( pool, "bad expires code, numeric value expected
<num> '",
> 
> Ummm, at a minimum, that should be if (isdigit(word[0])).

Sorry, its been a long day. I will at least make the code correct (well, it
would have worked, but it isn't right).

> 
> I can see six things in that little bit of code that I would feel compelled
> to change were I to actually look at the file, so I think I'll let
> someone else do it.  ;-)

I don't even want to ask what the other 5 are.

Cheers,

Ben.

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message