httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@liege.ICS.UCI.EDU>
Subject Re: cvs commit: apache/src mod_expires.c
Date Wed, 04 Dec 1996 22:01:22 GMT
>   --- 278,284 ----
>         while ( word[0] ) {
>     	/* <num>
>     	 */
>   ! 	if ( isdigit(word[0]) != NULL ) {
>     	    num = atoi( word );
>     	} else {
>                 return pstrcat( pool, "bad expires code, numeric value expected <num>
'",

Ummm, at a minimum, that should be if (isdigit(word[0])).

I can see six things in that little bit of code that I would feel compelled
to change were I to actually look at the file, so I think I'll let
someone else do it.  ;-)

......Roy

Mime
View raw message