httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Re: escape_uri bug fix never applied
Date Sun, 01 Dec 1996 12:59:27 GMT
Roy T. Fielding wrote:
> 
> I have tested the following patch after verifying with the new URL spec.
> This affects URLs that are returned in the Location header and in
> some error messages.  How about a couple +1s before 1.2b1?

Errr ... what new URL spec?

What about os_escape_path()?

Cheers,

Ben.

> 
> .....Roy
> 
> Index: util.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/util.c,v
> retrieving revision 1.32
> diff -c -r1.32 util.c
> *** util.c	1996/11/18 19:56:29	1.32
> --- util.c	1996/11/30 09:27:02
> ***************
> *** 845,855 ****
>       register int x,y;
>       char *copy = palloc (p, 3 * strlen (uri) + 1);
>               
> !     for(x=0,y=0; uri[x]; x++,y++) {
> !         if (ind (":% ?+&",(copy[y] = uri[x])) != -1) {
>               c2x(uri[x],&copy[y]);
>               y+=2;
>           }
>       }
>       copy[y] = '\0';
>       return copy;
> --- 845,856 ----
>       register int x,y;
>       char *copy = palloc (p, 3 * strlen (uri) + 1);
>               
> !     for (x=0,y=0; uri[x]; x++,y++) {
> !         if ((uri[x] <= ' ') || (ind("\"%&+<=>?", uri[x]) != -1)) {
>               c2x(uri[x],&copy[y]);
>               y+=2;
>           }
> +         else copy[y] = uri[x];
>       }
>       copy[y] = '\0';
>       return copy;

-- 
Ben Laurie                Phone: +44 (181) 994 6435  Email: ben@algroup.co.uk
Freelance Consultant and  Fax:   +44 (181) 994 6472
Technical Director        URL: http://www.algroup.co.uk/Apache-SSL
A.L. Digital Ltd,         Apache Group member (http://www.apache.org)
London, England.          Apache-SSL author

Mime
View raw message