httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chuck Murcko <ch...@n2k.com>
Subject Re: proxy all-purpose patch
Date Tue, 10 Dec 1996 03:01:09 GMT
Roy T. Fielding liltingly intones:
> 
> > --- 164,179 ----
> >       memset(&server, '\0', sizeof(server));
> >       server.sin_family = AF_INET;
> >   
> > ! /* We break the URL into host, port, path-search */
> > ! 
> > !     if ((desthost = table_get(r->headers_in, "Host:")) == NULL)
> 
> That should be "Host"

Yep. It should.

> 
> > --- 181,208 ----
> >   	    memcpy(q, url, p-url);
> >   	    q[p-url] = '\0';
> >   	    url = p;
> > ! 	    desthost = q;
> >   	}
> > +     }
> >   
> > !     p = strchr(desthost, ':');
> > !     if (p != NULL)
> > !     {
> > !         *(p++) = '\0';
> > !         destport = atoi(p);
> > !         destportstr = p;
> > !     }
> 
> Hmmm, what happens on a URL like  http://site:/blah/blah  ?
> 

Not much that's good. I'll add an isdigit() test to guard against this.

It looks like 1.1b2's rolled, so this'll probably be in 1.1b3.

Thanks, Roy.

chuck
Chuck Murcko	N2K Inc.	Wayne PA	chuck@telebase.com
And now, on a lighter note:
Year, n.:
	A period of three hundred and sixty-five disappointments.
		-- Ambrose Bierce, "The Devil's Dictionary"

Mime
View raw message