httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Terbush <ra...@zyzzyva.com>
Subject CGI execution broken for non-virtualhosts
Date Fri, 06 Dec 1996 22:00:59 GMT
For those not getting cvs mail, I just checked in a fix that
corrects a thinko in the patch I submitted the other day to
print a warning when User/Group appears in <VirtualHosts>
whith suEXEC not enabled.

The problem would manifest itself for non-virtualhosts IF
suEXEC was enabled.

oops


  Modified:    src       CHANGES http_core.c
  Log:
  Fix thinko that would prevent CGI execution for non-virtualhosts
  when suEXEC was enabled.
  
  Revision  Changes    Path
  1.77      +3 -0      apache/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /export/home/cvs/apache/src/CHANGES,v
  retrieving revision 1.76
  retrieving revision 1.77
  diff -C3 -r1.76 -r1.77
  *** CHANGES	1996/12/05 11:07:29	1.76
  --- CHANGES	1996/12/06 21:51:31	1.77
  ***************
  *** 1,5 ****
  --- 1,8 ----
    Changes with Apache 1.2b2:
    
  +   *) Fixed problem in set_[user|group] that prevented CGI execution
  +      for non-virtualhosts when suEXEC was enabled.
  + 
      *) Added PORTING information file.  [Jim Jagielski]
    
      *) Added definitions for S_IWGRP and S_IWOTH to conf.h [Ben Laurie]
  
  
  
  1.52      +2 -2      apache/src/http_core.c
  
  Index: http_core.c
  ===================================================================
  RCS file: /export/home/cvs/apache/src/http_core.c,v
  retrieving revision 1.51
  retrieving revision 1.52
  diff -C3 -r1.51 -r1.52
  *** http_core.c	1996/12/01 20:28:21	1.51
  --- http_core.c	1996/12/06 21:51:32	1.52
  ***************
  *** 841,847 ****
    {
        if (!cmd->server->is_virtual) {
    	user_name = pstrdup (cmd->pool, arg);
  ! 	user_id = uname2id(arg);
        }
        else {
    	if (suexec_enabled)
  --- 841,847 ----
    {
        if (!cmd->server->is_virtual) {
    	user_name = pstrdup (cmd->pool, arg);
  ! 	cmd->server->server_uid = user_id = uname2id(arg);
        }
        else {
    	if (suexec_enabled)
  ***************
  *** 859,865 ****
    const char *set_group (cmd_parms *cmd, void *dummy, char *arg)
    {
        if (!cmd->server->is_virtual)
  ! 	group_id = gname2id(arg);
        else {
    	if (suexec_enabled)
    	    cmd->server->server_gid = gname2id(arg);
  --- 859,865 ----
    const char *set_group (cmd_parms *cmd, void *dummy, char *arg)
    {
        if (!cmd->server->is_virtual)
  ! 	cmd->server->server_gid = group_id = gname2id(arg);
        else {
    	if (suexec_enabled)
    	    cmd->server->server_gid = gname2id(arg);
  
  


Mime
View raw message