httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Hartill <r...@imdb.com>
Subject apache_1.2b1: minor patch (fwd)
Date Wed, 04 Dec 1996 15:56:52 GMT

patch for proxy_http.c

----- Forwarded message from Martin Kraemer -----

Subject: apache_1.2b1: minor patch
To: apache-bugs@apache.org
Date: Wed, 4 Dec 1996 16:13:03 +0100 (MET)
From: Martin Kraemer <Martin.Kraemer@mch.sni.de>

Hello Rob,

Just a minor patch: the pointer should only be dereferenced after it is
tested not to be NULL:

Index: proxy_http.c
===================================================================
RCS file: /home/cvs/apache_1.2b1/src/modules/proxy/proxy_http.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 proxy_http.c
--- proxy_http.c	1996/12/04 12:59:47	1.1.1.1
+++ proxy_http.c	1996/12/04 15:10:49
@@ -308,7 +308,7 @@
 /* check if NoCache directive on this host */
     for (i=0; i < conf->nocaches->nelts; i++)
     {
-        if (ent[i].name[0] == '*' || (ent[i].name != NULL &&
+	if (ent[i].name != NULL && (ent[i].name[0] == '*' ||
           strstr(host, ent[i].name) != NULL))
 	    nocache = 1; 
     }

-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

----- End of forwarded message from Martin Kraemer -----


Mime
View raw message