Received: by taz.hyperreal.com (8.7.6/V2.0) id FAA11407; Mon, 11 Nov 1996 05:42:05 -0800 (PST) Received: from bcc.louisville.edu by taz.hyperreal.com (8.7.6/V2.0) with ESMTP id FAA11402; Mon, 11 Nov 1996 05:42:02 -0800 (PST) Received: from bcc.louisville.edu (jad@bcc.louisville.edu [136.165.140.24]) by bcc.louisville.edu (8.7.6/8.7.3) with SMTP id IAA10569 for ; Mon, 11 Nov 1996 08:39:44 -0500 Date: Mon, 11 Nov 1996 08:39:39 -0500 (EST) From: "Jason A. Dour" To: new-httpd@hyperreal.com Subject: Re: last post on suexec tonight, I swear In-Reply-To: <199611110035.TAA13637@shado.jaguNET.com> Message-ID: Comments: Getting paid to be a geek is cool... MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-new-httpd@apache.org Precedence: bulk Reply-To: new-httpd@hyperreal.com -----BEGIN PGP SIGNED MESSAGE----- On Sun, 10 Nov 1996, Jim Jagielski wrote: > Well, here it is in it's entirety... I think I may have been working > the copy of suexec in the CVS tree but seem to recall that you or Jason > had some updates as well. I've been delinquent in responding to you... I never did force myself to free up some time to look at your patches. I'll try to cover them now... First, a simple thing... 'asuser' as the name of the flag variable for ~userdir is, to me, a misleading name. All suexec functionality is running as some user. I'd rather leave it as 'homedir' or possibly change it to 'userdir', just to make certain it is distinct in the code...'asuser' wouldn't seem to stand out since that's the basic premise of the code... Nitpicky...but still... > #ifdef USE_SUEXEC_H > #include "suexec.h" > #endif This is mainly a style question...but why go and create another file for this stuff if you only need it for this code? This may change if we decide to use some of these defines in the server, I guess. Hmm. 6/half-dozen to me. > #ifdef HAVE_RLIMIT Randy and I agreed this was a Good Thing. +1 from me. > /* > * ALLOW_SUBDIRS -- Define this if you want to allow suexec > * to handle subdirectories. default is NO > */ > #ifndef ALLOW_SUBDIRS > #undef ALLOW_SUBDIRS > #endif I would consider the ALLOW_SUBDIRS related code to be a Bad Thing. That's MHO, though. Since the server chdir's to the location of the CGI, there should be no need for this, right? If there is a need, please give me an example... The other changes all seem to be built around having ALLOW_SUBDIRS in there...something I give a -1 to, unless a compelling reason as to why can be given... Jason # Jason A. Dour 1101 # Programmer Analyst II; Department of Radiation Oncology; Univ. of Lou. # Finger for URLs, PGP public key, geek code, PJ Harvey info, et cetera. -----BEGIN PGP SIGNATURE----- Version: 2.6.2 iQCVAwUBMocsnpo1JaC71RLxAQH+dQP/RVLqvsB7MMXaU7y6U8iX/HG+LZqLxIFm wGM7PerThtYvgWD7XNnLt5r1ob5KsoX7qkJ6HG69KAQBQOTmGd63Jjx8bkarAncs rPz0bzQ/FNthgJhQBwX4CJAVfORI8r8iu5WAREFgO+Lv+ZO2ZpKsVrljo7hIXyIF drNwTHkuTIM= =q738 -----END PGP SIGNATURE-----