httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@kiwi.ICS.UCI.EDU>
Subject Re: escape_uri bug fix never applied
Date Sat, 30 Nov 1996 09:30:46 GMT
I have tested the following patch after verifying with the new URL spec.
This affects URLs that are returned in the Location header and in
some error messages.  How about a couple +1s before 1.2b1?

.....Roy

Index: util.c
===================================================================
RCS file: /export/home/cvs/apache/src/util.c,v
retrieving revision 1.32
diff -c -r1.32 util.c
*** util.c	1996/11/18 19:56:29	1.32
--- util.c	1996/11/30 09:27:02
***************
*** 845,855 ****
      register int x,y;
      char *copy = palloc (p, 3 * strlen (uri) + 1);
              
!     for(x=0,y=0; uri[x]; x++,y++) {
!         if (ind (":% ?+&",(copy[y] = uri[x])) != -1) {
              c2x(uri[x],&copy[y]);
              y+=2;
          }
      }
      copy[y] = '\0';
      return copy;
--- 845,856 ----
      register int x,y;
      char *copy = palloc (p, 3 * strlen (uri) + 1);
              
!     for (x=0,y=0; uri[x]; x++,y++) {
!         if ((uri[x] <= ' ') || (ind("\"%&+<=>?", uri[x]) != -1)) {
              c2x(uri[x],&copy[y]);
              y+=2;
          }
+         else copy[y] = uri[x];
      }
      copy[y] = '\0';
      return copy;

Mime
View raw message