httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@liege.ICS.UCI.EDU>
Subject Re: two discrepancies:
Date Sun, 10 Nov 1996 10:14:00 GMT
> It looks like module_names[] is now called preloaded_module_names[].
> That's a bit silly.  I'll see if there is an appropriate fix.

Argh! It was bad enough having one unnecessary module name structure,
but now we seem to have two (in addition to the actual module name
which is the filename in the module list).  Would anyone mind if I
replaced the existing module_names[] indices with a simple traversal
of the module list?

The bug fix for httpd -h is below.  I'll commit it later.

.....Roy

Index: http_config.c
===================================================================
RCS file: /export/home/cvs/apache/src/http_config.c,v
retrieving revision 1.32
diff -c -r1.32 http_config.c
*** http_config.c       1996/11/04 18:09:55     1.32
--- http_config.c       1996/11/10 10:08:32
***************
*** 1127,1145 ****
  void show_directives()
  {
      extern module *prelinked_modules[];
-     extern char *module_names[];
      command_rec *pc;
      int n;
-     int t;
      
-     for(t=0 ; prelinked_modules[t] ; ++t)
-         ;
      for(n=0 ; prelinked_modules[n] ; ++n)
          for(pc=prelinked_modules[n]->cmds ; pc && pc->name ; ++pc) {
              printf("%s\n", pc->name);
              if (pc->errmsg)
                  printf("\t%s\n", pc->errmsg);
!             printf("\t%s\n", module_names[t-n-1]);
              show_overrides(pc, prelinked_modules[n]);
          }
  }
--- 1127,1141 ----
  void show_directives()
  {
      extern module *prelinked_modules[];
      command_rec *pc;
      int n;
      
      for(n=0 ; prelinked_modules[n] ; ++n)
          for(pc=prelinked_modules[n]->cmds ; pc && pc->name ; ++pc) {
              printf("%s\n", pc->name);
              if (pc->errmsg)
                  printf("\t%s\n", pc->errmsg);
!             printf("\t%s\n", prelinked_modules[n]->name);
              show_overrides(pc, prelinked_modules[n]);
          }
  }

Mime
View raw message