httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dgau...@hotwired.com (Dean Gaudet)
Subject Re: cvs commit: apache/src http_protocol.c
Date Mon, 04 Nov 1996 02:09:49 GMT
In article <hot.mailing-lists.new-httpd-Pine.SOL.3.93.961103133303.29864D-100000@eat.organic.com>,
Brian Behlendorf  <new-httpd@hyperreal.com> wrote:
>On Thu, 31 Oct 1996, Chuck Murcko wrote:
>> Not sure if the first try made it; here's another:
>> 
>> Is there any reason that
>> 
>>     if (r->finfo.st_mode != 0)
>>         sprintf(weak_etag, "W/\"%lx-%lx-%lx\"", (unsigned long)r->finfo.st_ino,
>> 		(unsigned long)r->finfo.st_size, mtime);
>> 
>> isn't portable? It fixes the warning everywhere here (FreeBSD, BSDI, Solaris,
>> Irix).
>
>No, that would seem to be the right fix, given all other conditions.  It works
>fine here too.  I've gone and committed it, even.

Doesn't this break when st_size is unsigned long long?  i.e. 64-bit
filesystems.

Dean

Mime
View raw message