httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@engelschall.com (Ralf S. Engelschall)
Subject Re: cvs commit: apache/src mod_rewrite.h Makefile.tmpl
Date Tue, 19 Nov 1996 10:39:47 GMT

In article <199611172053.MAA12765@taz.hyperreal.com> you wrote:
> brian       96/11/17 12:53:18

>   Modified:    src       mod_rewrite.h Makefile.tmpl
>   Log:
>   Fixed regex/regexp descrepancy, which was causing compile failures
>   with mod_rewrite.
>   
>   Revision  Changes    Path
>   1.9       +1 -1      apache/src/mod_rewrite.h
>   
>   Index: mod_rewrite.h
>   ===================================================================
>   RCS file: /export/home/cvs/apache/src/mod_rewrite.h,v
>   retrieving revision 1.8
>   retrieving revision 1.9
>   diff -C3 -r1.8 -r1.9
>   *** mod_rewrite.h	1996/10/31 17:19:36	1.8
>   --- mod_rewrite.h	1996/11/17 20:53:15	1.9
>   ***************
>   *** 108,114 ****
>            for Apache 1.2 and higher there is a Spencer POSIX library
>            in the distribution */
>     #ifndef HAS_APACHE_REGEX_LIB
>   ! #include "regexp/regexp.h"
>     #endif
>     
>     
>   --- 108,114 ----
>            for Apache 1.2 and higher there is a Spencer POSIX library
>            in the distribution */
>     #ifndef HAS_APACHE_REGEX_LIB
>   ! #include "regex/regex.h"
>     #endif

This patch IS WRONG! My code was correct! regexp/regexp.h exists on Apache
1.1.1 systems, where HAS_APACHE_REGEX_LIB is not defined.  The only correct
solution for Apache 1.2 would be to remove the dependency out of the Makefile
but let mod_rewrite.h as it is. Ok, one can remove the complete
HAS_APACHE_REGEX_LIB stuff, but then the code is not the same for all all
versions. When Apache 1.2 (not beta!) is released, I will remove all Apache
1.1.1 compatibility stuff. But up to this time it will stay in the code.

So, please revert the change of mod_rewrite.h and just let the dependency in
Makefile removed.

Greetings,
                                        Ralf S. Engelschall
                                        rse@engelschall.com
                                        http://www.engelschall.com/

Mime
View raw message