httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@organic.com>
Subject Re: user tracking module--on by default? (fwd)
Date Tue, 08 Oct 1996 06:22:20 GMT

>From a political and "least surprise" viewpoint, I think I agree, mod_usertrack
should be off by default even if compiled in.  I remember a long time ago we
talked about creating a "module coding style" document which suggests common
behaviors for modules, one of which being that a module should have no effect
even when compiled into the server unless it's specifically activated by a
directive.  Now, with <IfModule> sections, we can easily put directives in the
.conf files which are module-specific without worrying about minimal
compilations busting.  What do people think?

	Brian

On Wed, 2 Oct 1996, Rob Hartill wrote:
> I think I pointed this guy at from-cvs/ because he wanted to play
> the revamped mod_cookie/mod_usertrack
> 
> 
> ----- Forwarded message from David J MacKenzie -----
> 
> Date: Wed, 2 Oct 1996 16:30:22 -0400
> Message-Id: <QAA20367.199610022030@catapult.va.pubnix.com>
> From: David J MacKenzie <djm@va.pubnix.com>
> To: apache-bugs@apache.org
> Subject: user tracking module--on by default?
> X-Quote: 
>    We all agree on the necessity of compromise.  We just can't agree on
>    when it's necessary to compromise.  --Larry Wall
> 
> Most apache modules (status, anon_auth, cern_meta) don't automatically
> activate when linked in.  The development version of mod_usertrack
> does, though.  This is an undesirable behavior at our site, as well as
> being inconsistent with other modules.  I've applied this patch locally:
> 
> @@ -207,8 +207,12 @@
>      return (void *)cls;
>  }
>  
> -void *make_cookie_dir (pool *p, char *d) {
> -    return (void *)pcalloc(p, sizeof(int));
> +void *make_cookie_dir (pool *p, char *d)
> +{
> +    int *t = (int *)pcalloc(p, sizeof(int));
> +    *t = 1;
> +    return (void *)t;
> +
>  }
>  
>  char *set_cookie_disable (cmd_parms *cmd, int *c, int arg)
> 
> 
> ----- End of forwarded message from David J MacKenzie -----
> 
> 
> 

--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com  www.apache.org  hyperreal.com  http://www.organic.com/JOBS


Mime
View raw message