Message-Id: <199609161204.NAA00894>
Subject: Re: WWW Form Bug Report: "ErrorLog |.... does not work" on Solaris
 2.x
To: t@inac.co.jp
Date: Mon, 16 Sep 1996 13:04:00 +0100 (BST)
In-Reply-To: <199609161103.EAA20577@taz.hyperreal.com> from "t@inac.co.jp" at
 Sep 16, 96 04:03:35 am
From: Rob Hartill <robh@imdb.com>
Organization: Internet Movie Database
Content-Type: text
Sender: owner-new-httpd@apache.org
Precedence: bulk
Reply-To: new-httpd@hyperreal.com


thanks for the patch. I'll forward it to the developers list for
consideration.

regards,
rob

t@inac.co.jp wrote:
>
>Submitter: t@inac.co.jp
>Operating system: Solaris 2.x, version: 2.5 x86
>Version of Apache Used: 1.1.1
>Extra Modules used: 
>URL exhibiting problem: 
>
>Symptoms:
>--
>Patch for http_log.c here.
>
>*** http_log.c-dist     Mon Jul  1 06:48:02 1996
>--- http_log.c  Fri Sep 13 11:05:34 1996
>***************
>*** 86,101 ****
>    
>      fname = server_root_relative (p, s->error_fname);
>  
>!     if (*fname == '|') {
>        FILE *dummy;
>  
>!       spawn_child(p, error_log_child, (void *)(fname+1),
>                      kill_after_timeout, &dummy, NULL);
>  
>          if (dummy == NULL) {
>              fprintf (stderr, "Couldn't fork child for ErrorLog process\n");
>              exit (1);
>        }
>      } else {
>          if(!(s->error_log = pfopen(p, fname, "a"))) {
>              fprintf(stderr,"httpd: could not open error log file %s.\n", fname
>);
>--- 86,103 ----
>    
>      fname = server_root_relative (p, s->error_fname);
>  
>!     if (*s->error_fname == '|') {
>        FILE *dummy;
>  
>!       spawn_child(p, error_log_child, (void *)(s->error_fname+1),
>                      kill_after_timeout, &dummy, NULL);
>  
>          if (dummy == NULL) {
>              fprintf (stderr, "Couldn't fork child for ErrorLog process\n");
>              exit (1);
>        }
>+ 
>+       s->error_log = dummy;
>      } else {
>          if(!(s->error_log = pfopen(p, fname, "a"))) {
>              fprintf(stderr,"httpd: could not open error log file %s.\n", fname
>);
>
>--
>
>Backtrace:
>--
>
>--


-- 
Rob Hartill (robh@imdb.com)    
http://www.imdb.com/  ... why wait for a clear night to see the stars?.