httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <>
Subject Re: Too soon for 1.2 commits ??
Date Wed, 10 Jul 1996 19:14:34 GMT
Robert S. Thau wrote:
>   What I was objecting to was the implementation of strcasestr.
> So, I'll ask again --- what's wrong with it?  It could be made a bit
> faster, sure, but given where this routine is being called, I'm not sure
> that reducing its cost to zero would have a measurable impact on any
> useful measure of the server's end-to-end performance.  Given that,
> keeping the code simple and maintainable is by far the best policy.
> (Speed-bumming code can be useful, but only if you're tuning something
> that matters --- and generally, the only way to find these things for
> sure is with a profiler.  Without hard data --- at the very least, a
> sound benchmark by which one can measure the results --- it's generally
> counterproductive).

Oh absolutely, however, it seemed obvious to me that not only was the
implementation inefficient but it could be easily improved, probably with
benefit to readability. As, I think, Alexei has demonstrated.



> rst

Ben Laurie                  Phone: +44 (181) 994 6435
Freelance Consultant and    Fax:   +44 (181) 994 6472
Technical Director          Email:
A.L. Digital Ltd,           URL:
London, England.

View raw message