httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: apache/src mod_proxy.c (fwd)
Date Wed, 03 Jul 1996 15:12:55 GMT
Paul Richards wrote:
> 
> Ben Laurie writes:
>  > > 
>  > >   --- mod_proxy.c	1996/07/03 03:47:03	1.31
>  > >   ***************
>  > >   *** 1246,1252 ****
>  > >         const char *p, *q;
>  > >     
>  > >         q = get_time();
>  > >   !     p = strerror(errno);
>  > >     
>  > >         if (err != NULL)
>  > >         {
>  > >   --- 1246,1252 ----
>  > >         const char *p, *q;
>  > >     
>  > >         q = get_time();
>  > >   !     (char *)p = strerror(errno);
>  > 
>  > This is ridiculous. What warning does this fix?
>  > 
>  > I do object to fixing invalid warnings (and I find it hard to believe that this
>  > one is valid) in the mainline code.
> 
> The code is wrong, p should not be a "const char *", it's only used to
> pick up the error string from strerror and strerror returns a "char *".
> 

'const' is used the above way a few other places in proxy...

Did my previous message get through? (I haven't seen it here... It basically
said 'seem to me removing const is the better solution').

-- 
Jim Jagielski  << jim@jaguNET.com >>   |      "That's a Smith & Wesson,
  **  jaguNET Access Services  **      |       and you've had your six" 
      Email: info@jaguNET.com          |             - James Bond
++    http://www.jaguNET.com/         +++      Voice/Fax: 410-931-3157       ++

Mime
View raw message