httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexei Kosut <ako...@organic.com>
Subject Re: WWW Form Bug Report: "ScanHTMLTitles directive in .htaccess file not working" on BSDI (fwd)
Date Fri, 21 Jun 1996 16:42:44 GMT
On Fri, 21 Jun 1996, Ben Laurie wrote:

> > It does work, with one (possibly major) exception: the title tag *must* be
> > in uppercase letters, e.g. <TITLE> and </TITLE>. <title>, <Title>,
or any
> > other capitalization will not work. This is a misfeature (not quite a
> > bug), and will no doubt be changed in a future release.
> > 
> > However, with current Apache releases (most likely though the 1.1 final
> > release), you must use all-uppercase title tags.
> 
> Any reason we shouldn't fix it for 1.1 final? It sounds pretty trivial...

Not particuarly. Here's a patch. If no one minds, I'll commit it:

Index: mod_dir.c
===================================================================
RCS file: /export/home/cvs/apache/src/mod_dir.c,v
retrieving revision 1.9
diff -c -r1.9 mod_dir.c
*** mod_dir.c	1996/06/14 00:03:42	1.9
--- mod_dir.c	1996/06/21 16:41:59
***************
*** 470,476 ****
          n = fread(titlebuf,sizeof(char),MAX_STRING_LEN - 1,thefile);
          titlebuf[n] = '\0';
          for(x=0,p=0;titlebuf[x];x++) {
!             if(titlebuf[x] == find[p]) {
                  if(!find[++p]) {
                      if((p = ind(&titlebuf[++x],'<')) != -1)
                          titlebuf[x+p] = '\0';
--- 470,476 ----
          n = fread(titlebuf,sizeof(char),MAX_STRING_LEN - 1,thefile);
          titlebuf[n] = '\0';
          for(x=0,p=0;titlebuf[x];x++) {
!             if(toupper(titlebuf[x]) == find[p]) {
                  if(!find[++p]) {
                      if((p = ind(&titlebuf[++x],'<')) != -1)
                          titlebuf[x+p] = '\0';


-- Alexei Kosut <akosut@organic.com>            The Apache HTTP Server 
   http://www.nueva.pvt.k12.ca.us/~akosut/      http://www.apache.org/


Mime
View raw message