httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garey Smiley" <ga...@main.slink.com>
Subject Re: mod_proxy OS/2 fix.
Date Sat, 15 Jun 1996 14:12:31 GMT
On Fri, 14 Jun 1996 11:57:43 +0100 (BST), Ben Laurie wrote:

>> >> Could someone please commit this. OS/2 dosen't have link().
>> >> 
>> >> *** mod_proxy.c.orig	Sat Jun 08 16:21:28 1996
>> >> --- mod_proxy.c	Thu Jun 13 21:50:26 1996
>> >> ***************
>> >> *** 2081,2088 ****
>> >> --- 2081,2094 ----
>> >>               *p='/';
>> >>               ++p;
>> >>               }
>> >> + #ifdef __EMX__
>> >> +         /* Under OS/2 use rename. */            
>> >> +         if (rename(c->tempfile, c->filename) == -1)
>> >> +             log_uerror("rename", c->filename, "proxy: error renaming
>> >> cache file", s);
>> >> + #else            
>> >>           if (link(c->tempfile, c->filename) == -1)
>> >>               log_uerror("link", c->filename, "proxy: error linking
>> >> cache file", s);
>> >> + #endif            
>> >>           }
>> >>   
>> >>       if (unlink(c->tempfile) == -1)
>> >
>> >Doesn't the above cause this to fail on OS/2?
>> 
>> Why would it cause a failure?
>
>Because c->tempfile has been renamed to c->filename, so c->tempfile can't be
>deleted, no?

Oops. I will submit a new patch.


Garey Smiley
SoftLink Services
garey@slink.com
http://www.slink.com/
(216)848-1312 FAX/Data(216)699-4474

Mime
View raw message