httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: WWW Form Bug Report: "Status does not show non-proxied requests info" on Linux (fwd)
Date Fri, 28 Jun 1996 01:04:51 GMT
Aram Mirzadeh wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> 
> Jim Jagielski said:
> > 
> > As the code is right now, when in keepalive, the request field is left
> > alone and not touched. Thus, it will "keep" the previous entries, which
> > makes sense. Nothing else should be monkeying around with that slot
> > and the first thing that update_child_status() does it read the
> > slot info into the "workspace".
> > 
> > What did he consider as "wrong"? 
> 
> He said 'If you increase the keepalive and run a shell script using 
> <!--#exec "cmd"--> the status module reports the port as doing nothing.'
> 

Hmmm... I can't see where the scoreboard slot would be changed in the
process though... The only place it's touched is increment_counts()...

Can you ask him if this patch fixes it:

*** Ohttp_main.c	Thu Jun 27 17:25:44 1996
--- http_main.c	Thu Jun 27 20:57:55 1996
***************
*** 743,749 ****
  void increment_counts (int child_num, request_rec *r, int flag)
  {
      long int bs=0;
!     short_score new_score_rec=scoreboard_image[child_num];
  
      if (r->sent_bodyct)
          bgetopt(r->connection->client, BO_BYTECT, &bs);
--- 743,750 ----
  void increment_counts (int child_num, request_rec *r, int flag)
  {
      long int bs=0;
!     short_score new_score_rec;
!     memcpy(&new_score_rec,&scoreboard_image[child_num],sizeof new_score_rec);
  
      if (r->sent_bodyct)
          bgetopt(r->connection->client, BO_BYTECT, &bs);



-- 
Jim Jagielski  << jim@jaguNET.com >>   |      "That's a Smith & Wesson,
  **  jaguNET Access Services  **      |       and you've had your six" 
      Email: info@jaguNET.com          |             - James Bond
++    http://www.jaguNET.com/         +++      Voice/Fax: 410-931-3157       ++

Mime
View raw message