Received: by taz.hyperreal.com (8.6.12/8.6.5) id CAA07869;
 Wed, 10 Apr 1996 02:01:40 -0700
Received: from dicsmss1.jrc.it by taz.hyperreal.com (8.6.12/8.6.5) with SMTP
 id CAA07864; Wed, 10 Apr 1996 02:01:34 -0700
Received: from  jrc.it (elect6.jrc.it) by dicsmss1.jrc.it (4.1/EB-950131-C)
	id AA08542; Wed, 10 Apr 96 11:04:07 +0200
Received: by  jrc.it (5.x/EB-950213-L)
	id AA15977; Wed, 10 Apr 1996 10:59:44 +0200
Date: Wed, 10 Apr 1996 10:59:44 +0200
From: "Dirk.vanGulik" <Dirk.vanGulik@jrc.it>
Message-Id: <9604100859.AA15977@ jrc.it>
To: new-httpd@hyperreal.com
Subject: mod_auth_msql.c
X-Sun-Charset: US-ASCII
Sender: owner-new-httpd@apache.org
Precedence: bulk
Reply-To: new-httpd@hyperreal.com
Status: O
X-Status: 


sorry, hit the send button to early, here is a diff to move
mod_auth_msql.c 0.5 into 0.6 with grp/gid bug fixed

As a minor issue. We have now a module which keeps open the
connection with the msql database between calls. This has the
following (dis)advantages

- seriously faster when on different machines
- a wee bit faster when msqld lives on the same box

- *each* child has a connection, so msqld runs out of
  connected clients early. (The compiled in max is low)
- costs a lot of file/socket descriptors
- troublesome closes when a child or msqld dies in mid-live
  with a lot of open crap somethines left behind (on solaris,
  NetBSD is less troublesome)

After extensive trials we decided that it aint worth it.

Any one cares to comment ? Should I make this an option ?

Dw.


----

diff -c3 mod_auth_msql.c /httpd/src/mod_auth_msql.c
*** mod_auth_msql.c     Fri Mar  1 15:20:32 1996
--- /httpd/src/mod_auth_msql.c  Sun Mar 17 21:19:35 1996
***************
*** 115,120 ****
--- 115,123 ----
   *              no good at all !
   *       0.3  Added 'Auth_MSQL_nopasswd' option
   *       0.4  Cleaned out the error messages mess.
+  *       0.6  Inconsistency with gid/grp in comment/token/source
+  *            Make sure you really use 'Auth_MSQLgrp_field' as
+  *            indicated above.
   */
  
  #include "httpd.h"
***************
*** 184,191 ****
      (void*)XtOffsetOf(msql_auth_config_rec, auth_msql_uname_field),
      OR_AUTHCFG, TAKE1, "The UserID field name must be set to something" },
  
! { "Auth_MSQLgid_field", msql_set_string_slot,
!     (void*)XtOffsetOf(msql_auth_config_rec, auth_msql_nopasswd),
      OR_AUTHCFG, TAKE1, 
        "GID field name must be set to something if you want to use groups" },
  
--- 187,194 ----
      (void*)XtOffsetOf(msql_auth_config_rec, auth_msql_uname_field),
      OR_AUTHCFG, TAKE1, "The UserID field name must be set to something" },
  
! { "Auth_MSQLgrp_field", msql_set_string_slot,
!     (void*)XtOffsetOf(msql_auth_config_rec, auth_msql_grp_field),
      OR_AUTHCFG, TAKE1, 
        "GID field name must be set to something if you want to use groups" },
  
***************
*** 219,225 ****
  
        /* force fast access over /dev/msql */
        if ((host) && (!(strcasecmp(host,"localhost"))))
!               *host='\0';
  
        if ((sock=msqlConnect(host)) == -1) {
                sprintf (msql_errstr,
--- 222,228 ----
  
        /* force fast access over /dev/msql */
        if ((host) && (!(strcasecmp(host,"localhost"))))
!               *host=NULL;
  
        if ((sock=msqlConnect(host)) == -1) {
                sprintf (msql_errstr,