httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Hartill <r...@imdb.com>
Subject Re: Bugs in apache 1.1b1 (mod_cookies.c, mod_proxy.c)
Date Tue, 23 Apr 1996 13:53:41 GMT

Thanks for the patches. In future you might want to make
comments on why the changes are needed.

regards,
rob


>[mod_cookies.c]
>
>--- mod_cookies.c.org	Mon Apr 22 20:55:39 1996
>+++ mod_cookies.c	Tue Apr 23 15:31:50 1996
>@@ -254,6 +254,7 @@
>     if (r->status != -1)
> 	sprintf(&tstr[strlen(tstr)], "%c%02ld%02ld] %d\n", sign, timz/3600,
> 		timz%3600, r->status);
>+    else
> 	sprintf(&tstr[strlen(tstr)], "%c%02ld%02ld] -\n", sign, timz/3600,
> 		timz%3600);
> 
>[mod_proxy.c]
>
>--- mod_proxy.c.org	Mon Apr 22 20:55:47 1996
>+++ mod_proxy.c	Tue Apr 23 15:25:33 1996
>@@ -1893,7 +1893,7 @@
> 		if (curpos == -1)
> 		    log_uerror("lseek", c->filename,
> 			       "proxy: error seeking on cache file",r->server);
>-		else if (write(c->fp->fd, buff, 35) == -1)
>+		else if (write(c->fp->fd, buff, 45) == -1)
> 		    log_uerror("write", c->filename,
> 			       "proxy: error updating cache file", r->server);
> 	    }
>@@ -1922,7 +1922,7 @@
> 		if (curpos == -1)
> 		    log_uerror("lseek", c->filename,
> 			       "proxy: error seeking on cache file",r->server);
>-		else if (write(c->fp->fd, buff, 35) == -1)
>+		else if (write(c->fp->fd, buff, 45) == -1)
> 		    log_uerror("write", c->filename,
> 			       "proxy: error updating cache file", r->server);
> 	    }
>@@ -2305,11 +2305,12 @@
>     parms = strchr(path, ';');
>     if (parms != NULL) *(parms++) = '\0';
> 
>+    server.sin_family = AF_INET;
>     server.sin_port = htons(port);
>     err = host2addr(host, &server.sin_addr);
>     if (err != NULL) return proxyerror(r, err); /* give up */
> 
>-    sock = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP);
>+    sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
>     if (sock == -1)
>     {
> 	log_uerror("socket", NULL, "proxy: error creating socket", r->server);
>@@ -2421,7 +2422,7 @@
> 	return SERVER_ERROR;
>     }
> 
>-    dsock = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP);
>+    dsock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
>     if (dsock == -1)
>     {
> 	log_uerror("socket", NULL, "proxy: error creating socket", r->server);
>@@ -2632,7 +2633,7 @@
> 	if (err != NULL) return proxyerror(r, err); /* give up */
>     }
> 
>-    sock = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP);
>+    sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
>     if (sock == -1)
>     {
> 	log_error("proxy: error creating socket", r->server);
>
>-- 
>Masahartu Onishi	onishi@nova.co.jp


-- 
Rob Hartill (robh@imdb.com)
The Internet Movie Database (IMDb)  http://www.imdb.com/
           ...more movie info than you can poke a stick at.

Mime
View raw message