httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Hartill <r...@imdb.com>
Subject Bug in mod_log_referer.c (fwd)
Date Tue, 09 Apr 1996 13:30:19 GMT

will ack

Date: Tue, 09 Apr 1996 11:38:03 +0000 (GMT)
From: "Dr. Nicko van Someren" <nicko@ant.co.uk>
Subject: Bug in mod_log_referer.c
To: apache-bugs@mail.apache.org
Message-ID: <Marcel-0.99-0409113803-63dVPI2@florence.ant.co.uk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-Transfer-Encoding: QUOTED-PRINTABLE
X-Organisation: Aleph One Ltd. / ANT Ltd.
X-Mailer: ANT RISCOS Marcel [ver 0.99i]

There seems to be a bug in the code that deals with checking against multip=
le 
referer ignore entries.  In the function referer_log_transaction the variab=
le
char **ptrptr is being incremented by the wrong amount.  The increent given
in the source is the size of each of the elements in the array but adding t=
o
a pointer in C does so in steps of the size of the item pointed to.  Thus i=
n
the case of mod_log_referer.c it the variable should be incremented by 1.

Here is the result of 'diff mod_log_referer.c mod_log_referer.c~'

195c195
< =09      ptrptr ++ ) 
---
> =09      ptrptr +=3D cls->referer_ignore_list->elt_size) 

I hope this is of help.

=09Nicko

-- 
Dr. Nicko van Someren.      Vox:(44)(1223) 567808     Fax:(44)(1223) 567801
mailto:nicko@ant.co.uk                          http://www.ant.co.uk/~nicko

----- End of forwarded message from Dr. Nicko van Someren -----

-- 
Rob Hartill (robh@imdb.com)
The Internet Movie Database (IMDb)  http://www.imdb.com/
           ...more movie info than you can poke a stick at.

Mime
View raw message