httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From (David Robinson)
Subject Re: Apache module "mod_expires.c"
Date Tue, 20 Feb 1996 12:03:00 GMT
>> That's intentional. Anyway, why was mod_expires using HTTP_TIME_FORMAT
>> instead of the read-made gm_timestr_822() routine in util.c??
>>  David.
>> -----------
>Ok, fine ;)  I guess I blinked and missed the message, I'll fix this shortly
>and follow up to Thomas with a more clueful answer.
>David?  I copied the strftime() semantics from http_protocol.c
>which it used in http_protocol.c's set_last_modified() call.  If
>this is equivalent to gm_timestr_822() then it looks like
>http_protocol.c needs to be 'reeducated'.  That said, http_protocol.c
>is the only other file using gm_timestr_822 which it uses in
>generating the basic header info in basic_http_header().

This routine _has_ been re-educated in 1.1b0; take another look at the
code. (In fact, it needs a little bit more tidying.)

>Your question could equally be, "why can't http_protocol.c make
>it's mind up how to do this?".  I'm all for a common time-string
>printing function by the way.  Can I be certain that gm_timestr_822()
>is effectively in the API and that future module designers can rely
>on its services?

In a word, yes.


View raw message