Received: by taz.hyperreal.com (8.6.12/8.6.5) id AAA14048; Tue, 5 Dec 1995 00:05:45 -0800 Received: from arachnet.algroup.co.uk by taz.hyperreal.com (8.6.12/8.6.5) with SMTP id AAA14041; Tue, 5 Dec 1995 00:05:36 -0800 Received: from heap.ben.algroup.co.uk by arachnet.algroup.co.uk id aa04228; 5 Dec 95 8:04 GMT Received: from gonzo.ben.algroup.co.uk by heap.ben.algroup.co.uk id aa07089; 5 Dec 95 7:48 GMT Subject: Re: bug in a contrib module (fwd) [1 of 3] To: new-httpd@hyperreal.com Date: Tue, 5 Dec 1995 07:48:59 +0000 (GMT) From: Ben Laurie In-Reply-To: from "Alexei Kosut" at Dec 4, 95 08:15:04 pm X-Mailer: ELM [version 2.4 PL24 PGP2] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1709 Message-ID: <9512050748.aa22860@gonzo.ben.algroup.co.uk> Sender: owner-new-httpd@apache.org Precedence: bulk Reply-To: new-httpd@apache.org > > On Mon, 4 Dec 1995, Rob Hartill wrote: > > > no ack sent. > > > > Can whoever is responsible send an ack. > > I'm responsible for mod_actions, I'll send an ack. > > > this is the first of 3 messages I'm going to forward on this > > subject. > > The third one was on mod_auth_msql, which isn't mine. Someone else can > take that. > > > > Basically, the code does not test for NULL return from table_get(), which > > > results in a segfault if you do not define an Action for a given directory. > > > This is a very bad error... > > He doesn't say what machine/compiler/etc, he is using (I'll ask him in his > email), but it works fine for me. What his code does (the second version) > is to basically replace a !strcmp(..., NULL) with !(...), where ... is a > *char from a table_get. I think I'll end up using his version, beacuse > it's more compact, but is there any reason the former would result in a > seg fault? Absolutely. An access to NULL _is_ a seg fault. You should never strcmp a NULL pointer. > On my HP-UX 9.04 box, I can run Apache + mod_actions without > any Action directives anywhere, and it works fine... can anyone > confirm/deny this? > > --/ Alexei Kosut /--------/ Lefler on IRC > ----------------------------/ > The viewpoints expressed above are entirely false, and in no way > represent Alexei Kosut nor any other person or entity. /-------------- > > -- Ben Laurie Phone: +44 (181) 994 6435 Freelance Consultant Fax: +44 (181) 994 6472 and Technical Director Email: ben@algroup.co.uk A.L. Digital Ltd, URL: http://www.algroup.co.uk London, England.