Message-Id: <199512021628.KAA04676@sierra.zyzzyva.com>
To: new-httpd@hyperreal.com
Subject: Re: 1.0 release sources and the Binary release 
In-reply-to: ben's message of Sat, 02 Dec 1995 15:43:13 +0000.
         <9512021543.aa14038@gonzo.ben.algroup.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 02 Dec 1995 10:28:05 -0600
From: Randy Terbush <randy@zyzzyva.com>
Sender: owner-new-httpd@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

> It has bugs (however, I back the principle):
> 

> > ***************
> > *** 156,161 ****
> > --- 156,163 ----
> >   
> >       for (r = orig; r->next; r = r->next)
> >           continue;
> > +     if (cls->fname == "")	/* Don't log agent */
>                        ^^^^^ Oooops!
> > + 	return DECLINED;

Not sure I understand why this is wrong. It is a comparision
and not an assignment. The cls->fname is initialized to "".
Splain me please.


> >       if (cls->log_fd > 0) return; 
> > !     if(*cls->fname != NULL) {
> 
> This construction is, strictly, wrong (though it usually works). It irritates
> me to see it, the correct thing to say is:
> 
>      if(*cls->fname != '\0') {
> 
> I know this appears all over the place. Its one of the things I intend to fix
> post-1.0.0.
> 
> > !       if((cls->log_fd = popenf(p, fname, cookie_flags, cookie_mode)) < 0) 

Agreed. I should know better since I have fixed this problem many times
on other projects and other compilers.