httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam Sussman <mydd...@vidya.com>
Subject Re: mod_actions (patch and questions)
Date Fri, 15 Dec 1995 03:13:52 GMT
This module has a couple of other problems.  It does not re-esape the uri or
preserve the query string before issuing its redirect.  Here is a patch that
I use.  It includes your patch.


*** mod_actions.c.orig	Thu Dec 14 18:48:53 1995
--- mod_actions.c	Thu Dec 14 19:07:12 1995
***************
*** 129,135 ****
      action_dir_config *conf =
        (action_dir_config *)get_module_config(r->per_dir_config, &action_module);
  
!     if (!strcmp(table_get(conf->action_types,  r->content_type), NULL))
          return(DECLINED);
  
      if (r->finfo.st_mode == 0) {
--- 129,135 ----
      action_dir_config *conf =
        (action_dir_config *)get_module_config(r->per_dir_config, &action_module);
  
!     if (table_get(conf->action_types,  r->content_type) == NULL)
          return(DECLINED);
  
      if (r->finfo.st_mode == 0) {
***************
*** 137,144 ****
          return NOT_FOUND;
      }
  
!     internal_redirect(pstrcat (r->pool, table_get(conf->action_types,  
!                       r->content_type), r->uri, NULL),r);
      return OK;
  }
  
--- 137,150 ----
          return NOT_FOUND;
      }
  
!     if (r->args != NULL)
!     	internal_redirect(pstrcat (r->pool, table_get(conf->action_types,  
!                       r->content_type), escape_uri(r->pool, r->uri),
! 		      "?", r->args, NULL),r);
!     else
!     	internal_redirect(pstrcat (r->pool, table_get(conf->action_types,  
!                       r->content_type), escape_uri(r->pool, r->uri),
! 		      r->uri, NULL),r);
      return OK;
  }
  

Mime
View raw message