httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Terbush <ra...@zyzzyva.com>
Subject Re: 1.0 release sources and the Binary release
Date Sat, 02 Dec 1995 16:28:05 GMT
> It has bugs (however, I back the principle):
> 

> > ***************
> > *** 156,161 ****
> > --- 156,163 ----
> >   
> >       for (r = orig; r->next; r = r->next)
> >           continue;
> > +     if (cls->fname == "")	/* Don't log agent */
>                        ^^^^^ Oooops!
> > + 	return DECLINED;

Not sure I understand why this is wrong. It is a comparision
and not an assignment. The cls->fname is initialized to "".
Splain me please.


> >       if (cls->log_fd > 0) return; 
> > !     if(*cls->fname != NULL) {
> 
> This construction is, strictly, wrong (though it usually works). It irritates
> me to see it, the correct thing to say is:
> 
>      if(*cls->fname != '\0') {
> 
> I know this appears all over the place. Its one of the things I intend to fix
> post-1.0.0.
> 
> > !       if((cls->log_fd = popenf(p, fname, cookie_flags, cookie_mode)) < 0)


Agreed. I should know better since I have fixed this problem many times
on other projects and other compilers.




Mime
View raw message