httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject Votes
Date Thu, 12 Oct 1995 12:01:50 GMT
My votes:

+1 01_http_config.0.8.14.patch
0  02_DBMGroupCoreFix.0.8.14.patch	I don't use DBM (yet)
+1 04aExtraPath.0.8.14.patch [apres correction]
+1 05_NoKill.0.8.14.patch
+1 06_SCODocFix.0.8.14.patch
+1 07_SocketMemLeak.0.8.14.patch
+1 08_license.0.8.14.patch	(even though it was made in entirely the wrong directory)
+1 09_HP_comment.0.8.14.patch
+1 10_mutual-failure.0.8.14.patch
+1 11_fd_removal.0.8.14.patch
+1 12_del_max_security.0.8.14.patch
0  13_error_fd.0.8.14.patch
+1 14_rlimit.0.8.14.patch
+1 15_urlchars.0.8.14.patch
+1 16_alias.0.8.14.patch
-1 17_const.0.8.14.patch	Cleanups verboten
+1 18_geteuid.apache_0.8.14.patch
+1 19_redir.0.8.14.patch
+1 20_score.0.8.14.patch
+1 21.escape.0.8.14.patch
+1 22.spawn.0.8.14.patch
-1 23.mmap.0.8.14.patch		This must wait for 1.0
+1 24_imap.0.8.14.patch
-1 25_startserver.0.8.14.patch

13 is an enhancement, and I don't have time to test it properly. It looks right
and it compiles (on SCO).

I'm not super-happy about 19 as it uses the (IMO) unclear function
escape_uri(), but it does fix a bug.

If 25 is going to be fixed, I think it should be done like this:

    if(daemons_to_start < daemons_min_free)
	daemons_to_start=daemons_min_free;
    if(daemons_to_start > daemons_max_free)
	daemons_to_start=daemons_max_free;

Or by eliminating daemons_to_start altogether.

Cheers,

Ben.


-- 
Ben Laurie                  Phone: +44 (181) 994 6435
Freelance Consultant        Fax:   +44 (181) 994 6472
and Technical Director      Email: ben@algroup.co.uk
A.L. Digital Ltd,
London, England.

Mime
View raw message